Wikipedia:Bots/Requests for approval/Addbot 31

Add links
From Wikipedia, the free encyclopedia
The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was Approved.

Addbot 31[edit]

Operator: Addshore (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 19:41, Friday February 1, 2013 (UTC)

Automatic, Supervised, or Manual: Automatic

Programming language(s): PHP

Source code available: On GitHub

Function overview: Bot rewrite, Performing all tasks at once including various minor changes

Edit period(s): Cont

Estimated number of pages affected: Many

Exclusion compliant (Yes/No): Yes

Already has a bot flag (Yes/No): Yes

Function details: The bot rewrite consists of two major parts, a listing process and a checking process. The Listing process does not edit, this takes various sources of articles (categories, toolserver reports e.t.c) and lists them for the bot to check 'at some point'. The Checking process then reads this list every (currently 1 min) performing multiple checks as listed below before editing if required. The bot will try and alter its rate of checking pages depending on how many pages it currently has in its queue.

  • For Articles
  • If any of the above have happened
    • General template fixes (taken from AWB) (Approved for use with AWB here)
    • Combine any maint templates into multipleIssues if there is more than one [4]
    • Fix whitespace (e.g. multiple new lines in a row) (Approved for use with AWB here)
  • For Images
    • If PDF tag as bad format (already approved here)
  • For UserTalk
    • If contains one of templates that needs to be substed do so (already approved here)
  • For Categories
  • For Sandboxes
    • Check if the header exists at the top, if not put it there (Arrpoved here [5]
  • My Bot Space
    • If the bot comes accross a page that is protected that it was planning on editing it will post it in its user space
    • If the bot finds a broken redirect (it redirects to itself) it will post it in its user space

The main changes to the tasks that I am currently performing is that they will all occur in single edits with increased small uncontroversial fixes. The bot is configurable from User:Addbot/config although some variables still need to be added.

Discussion[edit]

Any significant tests I performed in the bot sandbox have been posted below. ·Add§hore· Talk To Me! 21:23, 4 February 2013 (UTC)[reply] 

*Checking Kikin Inc

BAD Addshore, bad! Line 28 of run.php is a real no-no. 

eval(preg_replace("/(\<syntaxhighlight lang='php'\>|\<\/syntaxhighlight\>)/i","",$wiki->getpage("User:Addbot/config")));

Really, you shouldn't eval anything taken from an untrustworthy source, but from any unprotected wikipage? That's just asking for trouble. I've protected the page now, and you must remove that from the code. If you have to have your config on a wikipage, I would suggest using something like parse_ini_string().

Seriously, I can't stress enough how dangerous that code is. Not only could it be used to hack your bot, but it could also hack your server as well. (note: I have not reviewed the rest of the code) --Chris 17:14, 2 February 2013 (UTC)[reply]

I know it was a terrible way to do it,I was braindead at the time, I did have the page protected at one stage hence why I was using eval, going to do parse_ini_string() now. ·Add§hore· Talk To Me! 17:22, 2 February 2013 (UTC)[reply]
 Done Fixed ·Add§hore· Talk To Me! 19:25, 2 February 2013 (UTC)|2=eval FIXME fixed  Done[reply]

{{BAGAssistanceNeeded}} ·Add§hore· Talk To Me! 12:25, 4 February 2013 (UTC)[reply]

Trial[edit]

Approved for trial (50 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. MBisanz talk 14:15, 4 February 2013 (UTC)[reply]
Currently running each page through one by one although the post is made before I check the contents. First edit prompted me to add more checks when adding an orphan tag, previous to this I only had checks for removing. See here. Starting the trial as soon as Labs is fixed. ·Add§hore· Talk To Me! 15:28, 4 February 2013 (UTC)[reply]
As a quick reference: We worked off the list I compiled at GitHub John F. Lewis (talk) 21:30, 4 February 2013 (UTC)[reply]

Trial 2[edit]

Approved for trial (50 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. Let's do another trial to be sure. I appreciate the table, but you don't need to go to that effort for the ones it does right, just any errors. MBisanz talk 23:19, 4 February 2013 (UTC)[reply]
Restarting, Once Addshore remembers to set it to edit the mainspace and not sandbox. Posted on behalf of Addshore. John F. Lewis (talk) 23:26, 4 February 2013 (UTC)[reply]
I wanted to make sure I didn't miss anything :) Trial complete. This was run from the Database and was not checked until after all 50 edits were complete. You can see all of the 50 edits made here, see below for 3 more bugs that I have found, I think another trial after these bugs are fixed would be good. ·Add§hore· Talk To Me! 23:56, 4 February 2013 (UTC)[reply]
  • Edit [7],[8][9] [10]seemed to add deadend when page was not a deadend. I think this is due to some of the characters that were used on the pages in the links. Am looking into this now  Fixed
  • Edit [11] seemed to remove unref tag when i cannot see any references. No idea why this has happened so will look into it.  Fixed
  • Edit [12] has an error in the edit summary, it looks like the bot added {{Sections}} when infact it removed it. Should be an easy fix.  Fixed

Trial 3[edit]

Approved for trial (50 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. Let's do another trial because we're finding and fixing stuff still. MBisanz talk 00:37, 5 February 2013 (UTC)[reply]
Perfect, will run a few sandbox tests over the articles that previously hit bugs before starting the trial. ·Add§hore· Talk To Me! 00:39, 5 February 2013 (UTC)[reply]
All of the bugs above are now fine. Also someone mentioned a vbug on my talkpage where BLP unsourced and Unreferenced were switched for non BLP's, this was due to incorrect regex. I have  Fixed the regex and added an extra check to this part of the bot. Just about to run the next 50 edits. ·Add§hore· Talk To Me! 01:00, 5 February 2013 (UTC)[reply]
Trial complete. 49/50 edits went as expected. The last edit with discussion here seems to still have a problem switching Unreferenced and BLP unsourced tags. Looking into it now, would be good to have another trial after this is fixed, i will also try and find some of the less common changes for the bot to hit, i.e. stubs, deadend, wikify, dating, double redirects. ·Add§hore· Talk To Me! 01:37, 5 February 2013 (UTC)[reply]
 Fixed the bug per this commit. Would love another trial to try and gain some more variety of types of changes. ·Add§hore· Talk To Me! 01:48, 5 February 2013 (UTC)[reply]

Trial 4[edit]

Approved for trial (100 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. Sure thing. MBisanz talk 03:07, 5 February 2013 (UTC)[reply]
Just about to start the trial, some changes have happened to the bot this morning so I will try and test these features in particular. ·Add§hore· Talk To Me! 10:42, 5 February 2013 (UTC)[reply]
Trial complete., I have a few more small checks regarding the {{Empty section}} template to add. Throughout the run I made lots of other small tweaks and toward the end of the run the but seemed to be getting everything right. I think 1 more trial would be good to stand as a final test. ·Add§hore· Talk To Me! 18:33, 8 February 2013 (UTC)[reply]
I have made the slight changes to the Bot making one change to when {{Empty section}} is added and also adding the below.
I am now ready for another trial. ·Add§hore· Talk To Me! 20:34, 8 February 2013 (UTC)[reply]

Trial 5[edit]

Approved for trial (100 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. Sure thing. MBisanz talk 03:10, 9 February 2013 (UTC)[reply]
Trial complete. A user has requested the attention of a member of the Bot Approvals Group. Once assistance has been rendered, please deactivate this tag by replacing it with {{t|BAG assistance needed}}. . I made a few more changes to the identification of BLP articles which seems to be working now. I also fixed a bug where templates were being added above HAT notes, and also then the bot was dragging up hat noes from sections to the top (also fixed). Just spotted one final issue with an edit summary at the end but other than that I think we are there. ·Add§hore· Talk To Me! 19:51, 9 February 2013 (UTC)[reply]
 Approved. MBisanz talk 15:43, 11 February 2013 (UTC)[reply]
The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.
Retrieved from "https://en.wikipedia.org/w/index.php?title=Wikipedia:Bots/Requests_for_approval/Addbot_31&oldid=841906331"